From: Daniel Lenski Date: Sun, 15 Nov 2020 23:32:08 +0000 (-0800) Subject: GP: ask user to report unexpected value of X-Git-Tag: v8.20~383^2 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=c3c2565bc69d59f51837045c9760f8a00b986f35;p=users%2Fdwmw2%2Fopenconnect.git GP: ask user to report unexpected value of We don't know what this one means, but it seems likely that we need to do some special processing if this differs from the VPN server's external IP address. See https://gitlab.com/openconnect/openconnect/-/issues/193#note_447466255 for an example of this field observed "in the wild". Signed-off-by: Daniel Lenski --- diff --git a/gpst.c b/gpst.c index 686bde2b..b35f6fe5 100644 --- a/gpst.c +++ b/gpst.c @@ -511,6 +511,12 @@ static int gpst_parse_config_xml(struct openconnect_info *vpninfo, xmlNode *xml_ vpn_progress(vpninfo, PRG_DEBUG, _("Gateway address in config XML (%s) differs from external gateway address (%s).\n"), s, vpninfo->ip_info.gateway_addr); vpninfo->esp_magic = inet_addr(s); + } else if (!xmlnode_get_val(xml_node, "connected-gw-ip", &s)) { + if (strcmp(s, vpninfo->ip_info.gateway_addr)) + vpn_progress(vpninfo, PRG_DEBUG, _("Config XML address (%s) differs from external\n" + "gateway address (%s). Please report any this to\n" + ", including any problems\n" + "with ESP or other apparent loss of connectivity or performance.\n"), s, vpninfo->ip_info.gateway_addr); } else if (xmlnode_is_named(xml_node, "dns")) { for (ii=0, member = xml_node->children; member && ii<3; member=member->next) if (!xmlnode_get_val(member, "member", &s))