From: Marios Makassikis Date: Thu, 16 Mar 2023 13:40:43 +0000 (+0100) Subject: ksmbd: do not call kvmalloc() with __GFP_NORETRY | __GFP_NO_WARN X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=c1f461ed5d243090442a9c1b06dce3512f44296e;p=users%2Fjedix%2Flinux-maple.git ksmbd: do not call kvmalloc() with __GFP_NORETRY | __GFP_NO_WARN commit e416ea62a9166e6075a07a970cc5bf79255d2700 upstream. Commit 83dcedd5540d ("ksmbd: fix infinite loop in ksmbd_conn_handler_loop()"), changes GFP modifiers passed to kvmalloc(). This cause xfstests generic/551 test to fail. We limit pdu length size according to connection status and maximum number of connections. In the rest, memory allocation of request is limited by credit management. so these flags are no longer needed. Fixes: 83dcedd5540d ("ksmbd: fix infinite loop in ksmbd_conn_handler_loop()") Cc: stable@vger.kernel.org Signed-off-by: Marios Makassikis Acked-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/ksmbd/connection.c b/fs/ksmbd/connection.c index 2be9d7460494b..b8f9d627f241d 100644 --- a/fs/ksmbd/connection.c +++ b/fs/ksmbd/connection.c @@ -326,10 +326,7 @@ int ksmbd_conn_handler_loop(void *p) /* 4 for rfc1002 length field */ size = pdu_size + 4; - conn->request_buf = kvmalloc(size, - GFP_KERNEL | - __GFP_NOWARN | - __GFP_NORETRY); + conn->request_buf = kvmalloc(size, GFP_KERNEL); if (!conn->request_buf) break;