From: Vincent Guittot Date: Mon, 2 Dec 2024 17:45:56 +0000 (+0100) Subject: sched/fair: Fix sched_can_stop_tick() for fair tasks X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=c1f43c342e1f2e32f0620bf2e972e2a9ea0a1e60;p=users%2Fdwmw2%2Flinux.git sched/fair: Fix sched_can_stop_tick() for fair tasks We can't stop the tick of a rq if there are at least 2 tasks enqueued in the whole hierarchy and not only at the root cfs rq. rq->cfs.nr_running tracks the number of sched_entity at one level whereas rq->cfs.h_nr_running tracks all queued tasks in the hierarchy. Fixes: 11cc374f4643b ("sched_ext: Simplify scx_can_stop_tick() invocation in sched_can_stop_tick()") Signed-off-by: Vincent Guittot Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Dietmar Eggemann Link: https://lore.kernel.org/r/20241202174606.4074512-2-vincent.guittot@linaro.org --- diff --git a/kernel/sched/core.c b/kernel/sched/core.c index c6d8232ad9eea..3e5a6bf587f91 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -1341,7 +1341,7 @@ bool sched_can_stop_tick(struct rq *rq) if (scx_enabled() && !scx_can_stop_tick(rq)) return false; - if (rq->cfs.nr_running > 1) + if (rq->cfs.h_nr_running > 1) return false; /*