From: Xiaoli Feng <xifeng@redhat.com>
Date: Tue, 9 Apr 2019 02:48:33 +0000 (+0800)
Subject: common/rc: use _try_scratch_mount for scratch_remount
X-Git-Tag: v2022.05.01~1199
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=c1edf46dbc2b462cc96b5862e5506ae9a1de3475;p=users%2Fhch%2Fxfstests-dev.git

common/rc: use _try_scratch_mount for scratch_remount

When call _scratch_remount for cifs , it always requires to input
password. This will make generic/306 generic/452 failed because
cifs remount failed.

Signed-off-by: Xiaoli Feng <xifeng@redhat.com>
Reviewed-and-tested-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
---

diff --git a/common/rc b/common/rc
index 1fb6af4cc..92ef9c7d0 100644
--- a/common/rc
+++ b/common/rc
@@ -357,7 +357,7 @@ _scratch_remount()
     local opts="$1"
 
     if test -n "$opts"; then
-	mount -o "remount,$opts" $SCRATCH_MNT
+	_try_scratch_mount "-o remount,$opts"
     fi
 }
 
diff --git a/tests/overlay/035 b/tests/overlay/035
index f36c1e10c..c0aae935b 100755
--- a/tests/overlay/035
+++ b/tests/overlay/035
@@ -55,7 +55,7 @@ mkdir -p $lowerdir1 $lowerdir2 $upperdir $workdir
 $MOUNT_PROG -t overlay -o"lowerdir=$lowerdir2:$lowerdir1" \
 			$OVL_BASE_SCRATCH_MNT $SCRATCH_MNT
 touch $SCRATCH_MNT/foo 2>&1 | _filter_scratch
-_scratch_remount rw 2>&1 | _filter_ro_mount
+$MOUNT_PROG -o remount,rw $SCRATCH_MNT 2>&1 | _filter_ro_mount
 $UMOUNT_PROG $SCRATCH_MNT
 
 # Make workdir immutable to prevent workdir re-create on mount