From: Thomas Meyer Date: Tue, 29 Nov 2011 11:08:00 +0000 (+0000) Subject: enic: Use kcalloc instead of kzalloc to allocate array X-Git-Tag: v2.6.39-400.9.0~338^2~51 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=c10099d55afe8b2c3bd9c268138ba504a48ab6a1;p=users%2Fjedix%2Flinux-maple.git enic: Use kcalloc instead of kzalloc to allocate array The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 (cherry picked from commit a1de22191bc4c47ff50ef3274295f4384074696b) Signed-off-by: Thomas Meyer Signed-off-by: David S. Miller Signed-off-by: Joe Jin --- diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index 32475cb74f80..2f157d9c26fd 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -2385,7 +2385,7 @@ static int __devinit enic_probe(struct pci_dev *pdev, #endif /* Allocate structure for port profiles */ - enic->pp = kzalloc(num_pps * sizeof(*enic->pp), GFP_KERNEL); + enic->pp = kcalloc(num_pps, sizeof(*enic->pp), GFP_KERNEL); if (!enic->pp) { pr_err("port profile alloc failed, aborting\n"); err = -ENOMEM;