From: Zijun Hu <quic_zijuhu@quicinc.com>
Date: Sat, 27 Jul 2024 08:34:01 +0000 (+0800)
Subject: driver core: bus: Fix double free in driver API bus_register()
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=bfa54a793ba77ef696755b66f3ac4ed00c7d1248;p=users%2Fjedix%2Flinux-maple.git

driver core: bus: Fix double free in driver API bus_register()

For bus_register(), any error which happens after kset_register() will
cause that @priv are freed twice, fixed by setting @priv with NULL after
the first free.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20240727-bus_register_fix-v1-1-fed8dd0dba7a@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/base/bus.c b/drivers/base/bus.c
index 5bb1dca96242..abf090ace833 100644
--- a/drivers/base/bus.c
+++ b/drivers/base/bus.c
@@ -922,6 +922,8 @@ bus_devices_fail:
 	bus_remove_file(bus, &bus_attr_uevent);
 bus_uevent_fail:
 	kset_unregister(&priv->subsys);
+	/* Above kset_unregister() will kfree @priv */
+	priv = NULL;
 out:
 	kfree(priv);
 	return retval;