From: shamir rabinovitch Date: Wed, 26 Oct 2016 13:16:50 +0000 (-0700) Subject: RDS: rds debug messages are enabled by default X-Git-Tag: v4.1.12-92~45^2~7 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=be940b293efe52482079939ec360dba9c8166635;p=users%2Fjedix%2Flinux-maple.git RDS: rds debug messages are enabled by default rds use Kconfig option called "RDS_DEBUG" to enable rds debug messages. This option cause the rds Makefile to add -DDEBUG to the rds gcc command line. When CONFIG_DYNAMIC_DEBUG is enabled, the "DEBUG" macro is used by include/linux/dynamic_debug.h to decide if dynamic debug prints should be sent by default to the kernel log. rds should not enable this macro for production builds. Orabug: 24956522 Signed-off-by: shamir rabinovitch Reviewed-by: Wengang Wang Acked-by: Santosh Shilimkar Signed-off-by: Santosh Shilimkar --- diff --git a/net/rds/Makefile b/net/rds/Makefile index 19e54854ba2da..6150133be023a 100644 --- a/net/rds/Makefile +++ b/net/rds/Makefile @@ -13,5 +13,5 @@ obj-$(CONFIG_RDS_TCP) += rds_tcp.o rds_tcp-y := tcp.o tcp_connect.o tcp_listen.o tcp_recv.o \ tcp_send.o tcp_stats.o -ccflags-$(CONFIG_RDS_DEBUG) := -DDEBUG +ccflags-$(CONFIG_RDS_DEBUG) := -DRDS_DEBUG diff --git a/net/rds/rds.h b/net/rds/rds.h index 26b80b316b2ac..abfa291c0296c 100644 --- a/net/rds/rds.h +++ b/net/rds/rds.h @@ -44,7 +44,7 @@ #define KERNEL_HAS_ATOMIC64 #endif -#ifdef DEBUG +#ifdef RDS_DEBUG #define rdsdebug(fmt, args...) pr_debug("%s(): " fmt, __func__ , ##args) #else /* sigh, pr_debug() causes unused variable warnings */