From: Guenter Roeck <linux@roeck-us.net>
Date: Fri, 29 Aug 2025 13:49:51 +0000 (-0700)
Subject: hwmon: (ina238) Correctly clamp shunt voltage limit
X-Git-Tag: v6.17-rc5~14^2~1
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=bd7e7bc2cc2024035dfbc8239c9f4d8675793445;p=users%2Fgriffoul%2Flinux.git

hwmon: (ina238) Correctly clamp shunt voltage limit

When clamping a register value, the result needs to be masked against the
register size. This was missing, resulting in errors when trying to write
negative limits. Fix by masking the clamping result against the register
size.

Fixes: eacb52f010a80 ("hwmon: Driver for Texas Instruments INA238")
Cc: Nathan Rossi <nathan.rossi@digi.com>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---

diff --git a/drivers/hwmon/ina238.c b/drivers/hwmon/ina238.c
index 4d3dc018ead9..c6b2734898d0 100644
--- a/drivers/hwmon/ina238.c
+++ b/drivers/hwmon/ina238.c
@@ -379,7 +379,7 @@ static int ina238_write_in(struct device *dev, u32 attr, int channel,
 		regval = clamp_val(val, -163, 163);
 		regval = (regval * 1000 * 4) /
 			 (INA238_SHUNT_VOLTAGE_LSB * data->gain);
-		regval = clamp_val(regval, S16_MIN, S16_MAX);
+		regval = clamp_val(regval, S16_MIN, S16_MAX) & 0xffff;
 
 		switch (attr) {
 		case hwmon_in_max: