From: Matthew Auld Date: Wed, 22 May 2024 10:21:52 +0000 (+0100) Subject: drm/xe/device: move flr to devm X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=bc54f42c0efaa81b42b53ce5f2423f7778d82516;p=users%2Fdwmw2%2Flinux.git drm/xe/device: move flr to devm Should be called when driver is removed, not when this particular driver instance is destroyed. Signed-off-by: Matthew Auld Cc: Rodrigo Vivi Reviewed-by: Andrzej Hajda Link: https://patchwork.freedesktop.org/patch/msgid/20240522102143.128069-27-matthew.auld@intel.com --- diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c index 043697e9e1b69..866c996df27a8 100644 --- a/drivers/gpu/drm/xe/xe_device.c +++ b/drivers/gpu/drm/xe/xe_device.c @@ -381,7 +381,7 @@ static void xe_driver_flr(struct xe_device *xe) xe_mmio_write32(gt, GU_DEBUG, DRIVERFLR_STATUS); } -static void xe_driver_flr_fini(struct drm_device *drm, void *arg) +static void xe_driver_flr_fini(void *arg) { struct xe_device *xe = arg; @@ -586,7 +586,7 @@ int xe_device_probe(struct xe_device *xe) err = xe_devcoredump_init(xe); if (err) return err; - err = drmm_add_action_or_reset(&xe->drm, xe_driver_flr_fini, xe); + err = devm_add_action_or_reset(xe->drm.dev, xe_driver_flr_fini, xe); if (err) return err;