From: Jérôme Pouiller Date: Tue, 10 Mar 2020 10:13:52 +0000 (+0100) Subject: staging: wfx: fix warning about freeing in-use mutex during device unregister X-Git-Tag: irq-urgent-2020-03-29~3^2~9 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=bab0a0b03442a62fe3abefcb2169e0b9ff95990c;p=users%2Fdwmw2%2Flinux.git staging: wfx: fix warning about freeing in-use mutex during device unregister After hif_shutdown(), communication with the chip is no more possible. It the only request that never reply. Therefore, hif_cmd.lock is never unlocked. hif_shutdown() unlock itself hif_cmd.lock to avoid a potential warning during disposal of device. hif_cmd.key_renew_lock should also been unlocked for the same reason. Signed-off-by: Jérôme Pouiller Link: https://lore.kernel.org/r/20200310101356.182818-2-Jerome.Pouiller@silabs.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c index 2428363371fa1..7b732c531a74a 100644 --- a/drivers/staging/wfx/hif_tx.c +++ b/drivers/staging/wfx/hif_tx.c @@ -140,6 +140,7 @@ int hif_shutdown(struct wfx_dev *wdev) else control_reg_write(wdev, 0); mutex_unlock(&wdev->hif_cmd.lock); + mutex_unlock(&wdev->hif_cmd.key_renew_lock); kfree(hif); return ret; }