From: Miklos Szeredi <mszeredi@redhat.com>
Date: Tue, 24 Jan 2023 15:41:18 +0000 (+0100)
Subject: ovl: fix tmpfile leak
X-Git-Tag: dma-mapping-6.3-2022-02-27~89^2~1
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=baabaa505563362b71f2637aedd7b807d270656c;p=users%2Fhch%2Fdma-mapping.git

ovl: fix tmpfile leak

Missed an error cleanup.

Reported-by: syzbot+fd749a7ea127a84e0ffd@syzkaller.appspotmail.com
Fixes: 2b1a77461f16 ("ovl: use vfs_tmpfile_open() helper")
Cc: <stable@vger.kernel.org> # v6.1
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---

diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
index 6e4e65ee050d..140f2742074d 100644
--- a/fs/overlayfs/copy_up.c
+++ b/fs/overlayfs/copy_up.c
@@ -792,7 +792,7 @@ static int ovl_copy_up_tmpfile(struct ovl_copy_up_ctx *c)
 	if (!c->metacopy && c->stat.size) {
 		err = ovl_copy_up_file(ofs, c->dentry, tmpfile, c->stat.size);
 		if (err)
-			return err;
+			goto out_fput;
 	}
 
 	err = ovl_copy_up_metadata(c, temp);