From: Kuan-Wei Chiu Date: Tue, 26 Aug 2025 06:23:15 +0000 (+0800) Subject: mm/slub: Replace sort_r() with sort() for debugfs stack trace sorting X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=ba7a896427cbade13d30f3c7e18c15e8be243c18;p=users%2Fhch%2Fmisc.git mm/slub: Replace sort_r() with sort() for debugfs stack trace sorting The comparison function used to sort stack trace locations in debugfs never relied on the third argument. Therefore, sort_r() is unnecessary. Switch to sort() with a two-argument comparison function to keep the code simple and aligned with the intended usage. Signed-off-by: Kuan-Wei Chiu Reviewed-by: Harry Yoo Signed-off-by: Vlastimil Babka --- diff --git a/mm/slub.c b/mm/slub.c index 264fc76455d7..9074ce914e9e 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -7726,7 +7726,7 @@ static void *slab_debugfs_next(struct seq_file *seq, void *v, loff_t *ppos) return NULL; } -static int cmp_loc_by_count(const void *a, const void *b, const void *data) +static int cmp_loc_by_count(const void *a, const void *b) { struct location *loc1 = (struct location *)a; struct location *loc2 = (struct location *)b; @@ -7793,8 +7793,8 @@ static int slab_debug_trace_open(struct inode *inode, struct file *filep) } /* Sort locations by count */ - sort_r(t->loc, t->count, sizeof(struct location), - cmp_loc_by_count, NULL, NULL); + sort(t->loc, t->count, sizeof(struct location), + cmp_loc_by_count, NULL); bitmap_free(obj_map); return 0;