From: Christoph Hellwig Date: Sat, 29 Aug 2020 17:03:23 +0000 (+0200) Subject: umem: remove ->revalidate_disk X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=b886bb9a0cf657a5434b77e32e8536bf13e210f6;p=users%2Fhch%2Fblock.git umem: remove ->revalidate_disk ->revalidate_disk is only called during add_disk for pd, but at that point the driver has already set the capacity to the same value a little earlier, so this additional update is entirely superflous. Signed-off-by: Christoph Hellwig --- diff --git a/drivers/block/umem.c b/drivers/block/umem.c index 982732dbe82e..4c8320bfc46b 100644 --- a/drivers/block/umem.c +++ b/drivers/block/umem.c @@ -746,21 +746,6 @@ static void del_battery_timer(void) del_timer(&battery_timer); } -/* - * Note no locks taken out here. In a worst case scenario, we could drop - * a chunk of system memory. But that should never happen, since validation - * happens at open or mount time, when locks are held. - * - * That's crap, since doing that while some partitions are opened - * or mounted will give you really nasty results. - */ -static int mm_revalidate(struct gendisk *disk) -{ - struct cardinfo *card = disk->private_data; - set_capacity(disk, card->mm_size << 1); - return 0; -} - static int mm_getgeo(struct block_device *bdev, struct hd_geometry *geo) { struct cardinfo *card = bdev->bd_disk->private_data; @@ -781,7 +766,6 @@ static const struct block_device_operations mm_fops = { .owner = THIS_MODULE, .submit_bio = mm_submit_bio, .getgeo = mm_getgeo, - .revalidate_disk = mm_revalidate, }; static int mm_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)