From: Don Skidmore <donald.c.skidmore@intel.com>
Date: Fri, 18 Feb 2011 19:29:46 +0000 (+0000)
Subject: ixgbe: cleanup X540 PHY reset function pointer
X-Git-Tag: v2.6.39-rc1~468^2~170^2~9
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=b60c5dd31b053d008110a80aa4089d64cee60e8f;p=linux.git
ixgbe: cleanup X540 PHY reset function pointer
The X540 PHY reset pointer isn't currently used which is a good thing as it
wouldn't work as implemented. On top of that the X540 firmware is written
with the assumption that is does not need to be reset for proper
initialization so it's not needed. I'm just assigning the pointer at NULL
as the current implementation is rather misleading.
Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
Tested-by: Stephen Ko <stephen.s.ko@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
diff --git a/drivers/net/ixgbe/ixgbe_x540.c b/drivers/net/ixgbe/ixgbe_x540.c
index a6f06d59a64a..3229398630f6 100644
--- a/drivers/net/ixgbe/ixgbe_x540.c
+++ b/drivers/net/ixgbe/ixgbe_x540.c
@@ -712,7 +712,7 @@ static struct ixgbe_phy_operations phy_ops_X540 = {
.identify = &ixgbe_identify_phy_generic,
.identify_sfp = &ixgbe_identify_sfp_module_generic,
.init = NULL,
- .reset = &ixgbe_reset_phy_generic,
+ .reset = NULL,
.read_reg = &ixgbe_read_phy_reg_generic,
.write_reg = &ixgbe_write_phy_reg_generic,
.setup_link = &ixgbe_setup_phy_link_generic,