From: Zijun Hu <quic_zijuhu@quicinc.com>
Date: Mon, 24 Feb 2025 14:27:59 +0000 (+0800)
Subject: of: Correct property name comparison in __of_add_property()
X-Git-Tag: nvme-6.15-2025-04-02~41^2~23
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=b41838312e24f69d28d1b81c9b9beef55f31215d;p=nvme.git

of: Correct property name comparison in __of_add_property()

__of_add_property() compares property name by strcmp(), and that is
improper for SPARC which wants strcasecmp().

Fix by using dedicated property name comparison macro of_prop_cmp().

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20250224-of_bugfix-v1-3-03640ae8c3a6@quicinc.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 001ff6ce4abf..c810014957e8 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1651,7 +1651,7 @@ int __of_add_property(struct device_node *np, struct property *prop)
 	prop->next = NULL;
 	next = &np->properties;
 	while (*next) {
-		if (strcmp(prop->name, (*next)->name) == 0) {
+		if (of_prop_cmp(prop->name, (*next)->name) == 0) {
 			/* duplicate ! don't insert it */
 			rc = -EEXIST;
 			goto out_unlock;