From: Kent Overstreet <kent.overstreet@linux.dev>
Date: Tue, 24 Sep 2024 23:31:22 +0000 (-0400)
Subject: bcachefs: Fix incorrect IS_ERR_OR_NULL usage
X-Git-Tag: nvme-6.12-2024-10-31~23^2~20
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=b29c30ab48e0395a22ecf0b94443d16a8f493fb6;p=nvme.git

bcachefs: Fix incorrect IS_ERR_OR_NULL usage

Returning a positive integer instead of an error code causes error paths
to become very confused.

Closes: syzbot+c0360e8367d6d8d04a66@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/btree_node_scan.c b/fs/bcachefs/btree_node_scan.c
index b28c649c6838..1e694fedc5da 100644
--- a/fs/bcachefs/btree_node_scan.c
+++ b/fs/bcachefs/btree_node_scan.c
@@ -275,7 +275,7 @@ static int read_btree_nodes(struct find_btree_nodes *f)
 		w->ca		= ca;
 
 		t = kthread_run(read_btree_nodes_worker, w, "read_btree_nodes/%s", ca->name);
-		ret = IS_ERR_OR_NULL(t);
+		ret = PTR_ERR_OR_ZERO(t);
 		if (ret) {
 			percpu_ref_put(&ca->io_ref);
 			closure_put(&cl);