From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Fri, 1 Aug 2025 13:34:37 +0000 (+0300)
Subject: PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup()
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=b26fc701a25195134ff0327709a0421767c4c7b2;p=users%2Fjedix%2Flinux-maple.git

PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup()

There is a typo so we accidentally return positive EINVAL instead of
negative -EINVAL. Add the missing '-' character.

Fixes: 6aceb36f17ab ("PCI: xgene-msi: Restructure handler setup/teardown")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Acked-by: Marc Zyngier <maz@kernel.org>
Link: https://patch.msgid.link/aIzCbVd93ivPinne@stanley.mountain
---

diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c
index 0a37a3f1809c..654639bccd10 100644
--- a/drivers/pci/controller/pci-xgene-msi.c
+++ b/drivers/pci/controller/pci-xgene-msi.c
@@ -311,7 +311,7 @@ static int xgene_msi_handler_setup(struct platform_device *pdev)
 		msi_val = xgene_msi_int_read(xgene_msi, i);
 		if (msi_val) {
 			dev_err(&pdev->dev, "Failed to clear spurious IRQ\n");
-			return EINVAL;
+			return -EINVAL;
 		}
 
 		irq = platform_get_irq(pdev, i);