From: Mauro Carvalho Chehab Date: Thu, 10 Dec 2020 02:33:41 +0000 (-0800) Subject: spmi: get rid of a warning when built with W=1 X-Git-Tag: howlett/maple_spf/20210104~354^2~6 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=b1f0aeecd25ac11053997484510a43346297a42d;p=users%2Fjedix%2Flinux-maple.git spmi: get rid of a warning when built with W=1 The SPMI core complaing with this warning when built with W=1: drivers/spmi/spmi.c: In function ‘spmi_controller_remove’: drivers/spmi/spmi.c:548:6: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] 548 | int dummy; | ^~~~~ As the dummy var isn't needed, remove it. Link: https://lore.kernel.org/r/aacfd03835b7d1b3b6c21665b44000fe7242e535.1601360391.git.mchehab+huawei@kernel.org Reviewed-by: Stephen Boyd Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Stephen Boyd Link: https://lore.kernel.org/r/20201210023344.2838141-2-sboyd@kernel.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c index c16b60f645a4d..fd3ff6079b15d 100644 --- a/drivers/spmi/spmi.c +++ b/drivers/spmi/spmi.c @@ -545,13 +545,10 @@ static int spmi_ctrl_remove_device(struct device *dev, void *data) */ void spmi_controller_remove(struct spmi_controller *ctrl) { - int dummy; - if (!ctrl) return; - dummy = device_for_each_child(&ctrl->dev, NULL, - spmi_ctrl_remove_device); + device_for_each_child(&ctrl->dev, NULL, spmi_ctrl_remove_device); device_del(&ctrl->dev); } EXPORT_SYMBOL_GPL(spmi_controller_remove);