From: Colin Ian King Date: Thu, 20 Jan 2022 02:10:38 +0000 (-0800) Subject: lib: remove redundant assignment to variable ret X-Git-Tag: v5.17-rc1~38^2 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=b1e78ef3be2533973953a35a56739fda7325875c;p=users%2Fdwmw2%2Flinux.git lib: remove redundant assignment to variable ret The variable ret is being assigned a value that is never read. If the for-loop is entered then ret is immediately re-assigned a new value. If the for-loop is not executed ret is never read. The assignment is redundant and can be removed. Link: https://lkml.kernel.org/r/20211230134557.83633-1-colin.i.king@gmail.com Signed-off-by: Colin Ian King Reviewed-by: Jarkko Sakkinen Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/lib/asn1_encoder.c b/lib/asn1_encoder.c index 27bbe891714f9..0fd3c454a4689 100644 --- a/lib/asn1_encoder.c +++ b/lib/asn1_encoder.c @@ -164,8 +164,6 @@ asn1_encode_oid(unsigned char *data, const unsigned char *end_data, data_len -= 3; - ret = 0; - for (i = 2; i < oid_len; i++) { ret = asn1_encode_oid_digit(&d, &data_len, oid[i]); if (ret < 0)