From: Hanjun Guo <guohanjun@huawei.com>
Date: Wed, 2 Jun 2021 09:36:50 +0000 (+0800)
Subject: ACPI: bus: Call kobject_put() in acpi_init() error path
X-Git-Tag: v4.19.198~333
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=b020044bee32c599b3e25f0b110b6e25e7f789d7;p=users%2Fdwmw2%2Flinux.git

ACPI: bus: Call kobject_put() in acpi_init() error path

[ Upstream commit 4ac7a817f1992103d4e68e9837304f860b5e7300 ]

Although the system will not be in a good condition or it will not
boot if acpi_bus_init() fails, it is still necessary to put the
kobject in the error path before returning to avoid leaking memory.

Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index d60e57d14c859..d9dc9d2f38d56 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -1240,6 +1240,7 @@ static int __init acpi_init(void)
 	init_acpi_device_notify();
 	result = acpi_bus_init();
 	if (result) {
+		kobject_put(acpi_kobj);
 		disable_acpi();
 		return result;
 	}