From: Jose Abreu Date: Tue, 10 Sep 2019 14:41:24 +0000 (+0200) Subject: net: stmmac: xgmac: Reinitialize correctly a variable X-Git-Tag: v5.4-rc1~131^2~41^2~3 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=afdf26ab3c9b7bc13792fd55fc5f2878923fdf9d;p=users%2Fwilly%2Fxarray.git net: stmmac: xgmac: Reinitialize correctly a variable 'value' was being or'ed with a value from another register. This is a typo and could cause new written value to be wrong. Fix it. Signed-off-by: Jose Abreu Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c index 78ac659da279..d5173dd02a71 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c @@ -568,7 +568,7 @@ static void dwxgmac2_update_vlan_hash(struct mac_device_info *hw, u32 hash, writel(value, ioaddr + XGMAC_PACKET_FILTER); - value |= XGMAC_VLAN_VTHM | XGMAC_VLAN_ETV; + value = XGMAC_VLAN_VTHM | XGMAC_VLAN_ETV; if (is_double) { value |= XGMAC_VLAN_EDVLP; value |= XGMAC_VLAN_ESVL;