From: Daniel Wagner <dwagner@suse.de>
Date: Mon, 18 Oct 2021 09:24:34 +0000 (+0200)
Subject: build: Set minimum version for json-c
X-Git-Tag: v1.0-rc0~81^2
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=af3110a5cc0993a07d677383cd158cc77afdd92d;p=users%2Fsagi%2Flibnvme.git

build: Set minimum version for json-c

Set minimum version for json-c to 0.13.

libnvme uses json_util_get_last_err() which got introduced in 0.13,
released in December 2017.

While at it, drop the cc.find_library() lookup logic. First, we don't
do this for libuuid and second, dependency() is using pkg-config to
figure out the dependency, thus we can set the minimum version
number. Instead, cc.find_library() will try to link a test program
with '-libjson-c' and have no way to figure out which version it
actually is. Avoid any confusion and make the meson.build script
simpler.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
---

diff --git a/meson.build b/meson.build
index 6b4fd777..271c48a9 100644
--- a/meson.build
+++ b/meson.build
@@ -89,10 +89,7 @@ libuuid = dependency('uuid', required: true)
 conf.set('CONFIG_LIBUUID', libuuid.found(), description: 'Is libuuid required?')
 
 # Check for libjson-c availability
-libjson = dependency('json-c', required: false)
-if not libjson.found()
-    libjson = cc.find_library('json-c', required: true)
-endif
+libjson = dependency('json-c', version: '>=0.13', required: true)
 conf.set('CONFIG_JSONC', libjson.found(), description: 'Is json-c required?')
 
 # local (cross-compilable) implementations of ccan configure steps