From: David Oberhollenzer Date: Sun, 10 Nov 2019 13:52:05 +0000 (+0100) Subject: ubiformat: don't leak file descriptors X-Git-Tag: v2.1.2~20 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=af06f37bdee2097d23832da99a3e7725de2f695e;p=mtd-utils.git ubiformat: don't leak file descriptors The original code had a 'goto out_close' directly after a return error code, which is obviously not what was intended. Signed-off-by: David Oberhollenzer --- diff --git a/ubi-utils/ubiformat.c b/ubi-utils/ubiformat.c index a90627c..64afad2 100644 --- a/ubi-utils/ubiformat.c +++ b/ubi-utils/ubiformat.c @@ -426,8 +426,8 @@ static int flash_image(libmtd_t libmtd, const struct mtd_dev_info *mtd, } if (st_size % mtd->eb_size) { - return sys_errmsg("file \"%s\" (size %lld bytes) is not multiple of ""eraseblock size (%d bytes)", - args.image, (long long)st_size, mtd->eb_size); + sys_errmsg("file \"%s\" (size %lld bytes) is not multiple of ""eraseblock size (%d bytes)", + args.image, (long long)st_size, mtd->eb_size); goto out_close; }