From: Ilya Dryomov Date: Fri, 25 Aug 2017 12:04:41 +0000 (+0200) Subject: generic/420: truncate testfile before executing the test X-Git-Tag: v2022.05.01~1908 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=af04d7247fa3ca2a63f8523890ef9fff97522cf4;p=users%2Fhch%2Fxfstests-dev.git generic/420: truncate testfile before executing the test If generic/437 is run before generic/420, the latter fails with: 4c4 < stat.size = 2048 --- > stat.size = 2097152 because both use $TEST_DIR/testfile. generic/437 leaves it at 2M, while generic/420 assumes that it is empty (or at least smaller than 2048 bytes). Use a private test file (testfile.$seq) and truncate it on open just in case. Signed-off-by: Ilya Dryomov Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- diff --git a/tests/generic/420 b/tests/generic/420 index ccb6cb8e8..aab2e0885 100755 --- a/tests/generic/420 +++ b/tests/generic/420 @@ -52,10 +52,10 @@ _supported_os Linux _require_test _require_xfs_io_command fpunch -testfile="${TEST_DIR}/testfile" +testfile="${TEST_DIR}/testfile.$seq" echo "Testing fallocate(mode=FALLOC_FL_KEEP_SIZE|FALLOC_FL_PUNCH_HOLE)" -$XFS_IO_PROG -fc "pwrite -b 2048 0 2048" $testfile | head -n1 +$XFS_IO_PROG -f -t -c "pwrite -b 2048 0 2048" $testfile | head -n1 # fpunch from xfs_io has KEEP_SIZE flag set $XFS_IO_PROG -c "fpunch 2048 2048" $testfile $XFS_IO_PROG -c "stat" $testfile | grep -F 'stat.size'