From: Mike Gilbert <floppym@gentoo.org>
Date: Sun, 10 Apr 2022 20:22:45 +0000 (-0400)
Subject: Do not XFAIL obsolete-server-crypto on Fedora/CentOS
X-Git-Tag: v9.00~44^2
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=ae7f728cb009210d9c50e6033eb6911310460a64;p=users%2Fdwmw2%2Fopenconnect.git

Do not XFAIL obsolete-server-crypto on Fedora/CentOS

Signed-off-by: Mike Gilbert <floppym@gentoo.org>
---

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 5a4d68ce..e023926b 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -110,9 +110,8 @@ CentOS8/OpenSSL:
 # we don't want pppd to invoke any actual connection scripts
   - mv /etc/ppp /etc/ppp.DISABLED
 # auth-nonascii: UTF-8 support is not available in distro's ocserv package
-# obsolete-server-crypto: OpenSSL 1.1.0 disables 3DES and RC4 by default (https://www.openssl.org/blog/blog/2016/08/24/sweet32/)
 # ppp-over-tls-sync: https://gitlab.com/openconnect/openconnect/-/issues/287#note_641198529)
-  - make VERBOSE=1 XFAIL_TESTS="auth-nonascii obsolete-server-crypto ppp-over-tls-sync" -j4 check
+  - make VERBOSE=1 XFAIL_TESTS="auth-nonascii ppp-over-tls-sync" -j4 check
   tags:
   - shared
   except:
@@ -218,9 +217,8 @@ ubsan/OpenSSL/Fedora:
   - export UBCFLAGS="-Wall -Wextra -fsanitize=undefined -fsanitize=bool -fsanitize=alignment -fsanitize=null -fsanitize=bounds-strict -fsanitize=enum -fno-sanitize-recover -g -O2"
   - CFLAGS="$UBCFLAGS" ./configure --without-gnutls --with-openssl --without-openssl-version-check --disable-dsa-tests
   - make -j4
-# obsolete-server-crypto: OpenSSL 1.1.0 disables 3DES and RC4 by default (https://www.openssl.org/blog/blog/2016/08/24/sweet32/)
 # auth-swtpm: XFAIL until we understand the TPM error
-  - make VERBOSE=1 XFAIL_TESTS="obsolete-server-crypto auth-swtpm" -j4 check
+  - make VERBOSE=1 XFAIL_TESTS="auth-swtpm" -j4 check
   tags:
   - shared
   - linux
@@ -266,8 +264,7 @@ asan/OpenSSL/Fedora:
   - CC=clang CFLAGS="-fsanitize=address -fno-optimize-sibling-calls -fno-omit-frame-pointer -g -O1"
     ./configure --without-gnutls --with-openssl --without-openssl-version-check --disable-dsa-tests --without-asan-broken-tests
   - make -j4
-# obsolete-server-crypto: OpenSSL 1.1.0 disables 3DES and RC4 by default (https://www.openssl.org/blog/blog/2016/08/24/sweet32/)
-  - make VERBOSE=1 XFAIL_TESTS="obsolete-server-crypto" -j4 check
+  - make VERBOSE=1 -j4 check
   tags:
   - shared
   - linux
@@ -396,10 +393,9 @@ Fedora/OpenSSL:
 # we don't want pppd to invoke any actual connection scripts
   - mv /etc/ppp /etc/ppp.DISABLED
 # auth-nonascii: UTF-8 support is not available in distro's ocserv package
-# obsolete-server-crypto: OpenSSL 1.1.0 disables 3DES and RC4 by default (https://www.openssl.org/blog/blog/2016/08/24/sweet32/)
 # auth-swtpm: XFAIL until we understand the TPM error
 # ppp-over-tls-sync: https://gitlab.com/openconnect/openconnect/-/issues/287#note_641198529)
-  - make VERBOSE=1 XFAIL_TESTS="obsolete-server-crypto auth-swtpm ppp-over-tls-sync" -j4 check
+  - make VERBOSE=1 XFAIL_TESTS="auth-swtpm ppp-over-tls-sync" -j4 check
   tags:
   - shared
   except:
@@ -429,10 +425,9 @@ Fedora/OpenSSL/clang:
   - sysctl net.ipv6.conf.all.disable_ipv6=0
 # we don't want pppd to invoke any actual connection scripts
   - mv /etc/ppp /etc/ppp.DISABLED
-# obsolete-server-crypto: OpenSSL 1.1.0 disables 3DES and RC4 by default (https://www.openssl.org/blog/blog/2016/08/24/sweet32/)
 # auth-swtpm: XFAIL until we understand the TPM error
 # ppp-over-tls-sync: https://gitlab.com/openconnect/openconnect/-/issues/287#note_641198529)
-  - make VERBOSE=1 XFAIL_TESTS="obsolete-server-crypto auth-swtpm ppp-over-tls-sync" -j4 check
+  - make VERBOSE=1 XFAIL_TESTS="auth-swtpm ppp-over-tls-sync" -j4 check
   tags:
   - shared
   except: