From: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Date: Thu, 3 Jul 2025 06:46:20 +0000 (-0700)
Subject: staging: gpib: Fix error code in board_type_ioctl()
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=aa07b790d79226f9bd0731d2c065db2823867cc5;p=users%2Fjedix%2Flinux-maple.git

staging: gpib: Fix error code in board_type_ioctl()

When copy_from_user() fails it return number of bytes it wasn't able to
copy. So the correct return value when copy_from_user() fails is
-EFAULT.

Fixes: 9dde4559e939 ("staging: gpib: Add GPIB common core driver")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20250703064633.1955893-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/common/gpib_os.c
index 93ef5f6ce249c..4cb2683caf996 100644
--- a/drivers/staging/gpib/common/gpib_os.c
+++ b/drivers/staging/gpib/common/gpib_os.c
@@ -831,7 +831,7 @@ static int board_type_ioctl(struct gpib_file_private *file_priv,
 	retval = copy_from_user(&cmd, (void __user *)arg,
 				sizeof(struct gpib_board_type_ioctl));
 	if (retval)
-		return retval;
+		return -EFAULT;
 
 	for (list_ptr = registered_drivers.next; list_ptr != &registered_drivers;
 	     list_ptr = list_ptr->next) {