From: Colin Ian King <colin.king@canonical.com>
Date: Mon, 2 Dec 2019 18:59:42 +0000 (+0000)
Subject: cifs: remove redundant assignment to pointer pneg_ctxt
X-Git-Tag: v5.5-rc1~3^2~6
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=a9f76cf82719aea0f41bfcae57e17ffec39743d0;p=users%2Fwilly%2Flinux.git

cifs: remove redundant assignment to pointer pneg_ctxt

The pointer pneg_ctxt is being initialized with a value that is never
read and it is being updated later with a new value.  The assignment
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index ed77f94dbf1d..be0de8a63e57 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -554,7 +554,7 @@ static void
 assemble_neg_contexts(struct smb2_negotiate_req *req,
 		      struct TCP_Server_Info *server, unsigned int *total_len)
 {
-	char *pneg_ctxt = (char *)req;
+	char *pneg_ctxt;
 	unsigned int ctxt_len;
 
 	if (*total_len > 200) {