From: Wan Jiabing Date: Mon, 16 May 2022 08:50:00 +0000 (+0800) Subject: gpio: ftgpio: Remove unneeded ERROR check before clk_disable_unprepare X-Git-Tag: howlett/maple/20220722_2~441^2~7 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=a998ec3d7bae4f996bb9dcf6d0c76b6c812f267b;p=users%2Fjedix%2Flinux-maple.git gpio: ftgpio: Remove unneeded ERROR check before clk_disable_unprepare clk_disable_unprepare() already checks ERROR by using IS_ERR_OR_NULL. Remove unneeded ERROR check for g->clk. Signed-off-by: Wan Jiabing Signed-off-by: Bartosz Golaszewski --- diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c index b90a45c939a4b..f422c3e129a0c 100644 --- a/drivers/gpio/gpio-ftgpio010.c +++ b/drivers/gpio/gpio-ftgpio010.c @@ -315,8 +315,8 @@ static int ftgpio_gpio_probe(struct platform_device *pdev) return 0; dis_clk: - if (!IS_ERR(g->clk)) - clk_disable_unprepare(g->clk); + clk_disable_unprepare(g->clk); + return ret; } @@ -324,8 +324,8 @@ static int ftgpio_gpio_remove(struct platform_device *pdev) { struct ftgpio_gpio *g = platform_get_drvdata(pdev); - if (!IS_ERR(g->clk)) - clk_disable_unprepare(g->clk); + clk_disable_unprepare(g->clk); + return 0; }