From: Sui Jingfeng Date: Mon, 13 May 2024 15:31:01 +0000 (+0800) Subject: drm/bridge: panel: Remove a redundant check on existence of bridge->encoder X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=a8f856bf054aeba9bb9c1a8b296c61711e9d76fb;p=users%2Fdwmw2%2Flinux.git drm/bridge: panel: Remove a redundant check on existence of bridge->encoder Because the existence of 'bridge->encoder' has already been checked before the panel_bridge_attach() function get called, and the drm_bridge_attach() will quit with a negative error code returned if it fails for some reasons. Hence, it is guaranteed that the .encoder member of the drm_bridge instance is not NULL when panel_bridge_attach() function get called. Remove the redundant checking codes "if (!bridge->encoder) { ... }". Reviewed-by: Laurent Pinchart Signed-off-by: Sui Jingfeng Signed-off-by: Robert Foss Link: https://patchwork.freedesktop.org/patch/msgid/20240513153109.46786-5-sui.jingfeng@linux.dev --- diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c index 32506524d9a2d..56c40b516a8f0 100644 --- a/drivers/gpu/drm/bridge/panel.c +++ b/drivers/gpu/drm/bridge/panel.c @@ -67,11 +67,6 @@ static int panel_bridge_attach(struct drm_bridge *bridge, if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) return 0; - if (!bridge->encoder) { - DRM_ERROR("Missing encoder\n"); - return -ENODEV; - } - drm_connector_helper_add(connector, &panel_bridge_connector_helper_funcs);