From: Keith Busch <kbusch@kernel.org>
Date: Fri, 20 Dec 2019 17:15:36 +0000 (+0900)
Subject: micron: don't ignore 'system()' return value
X-Git-Tag: v1.10~10
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=a87657aa3f1e3d80cd47d682558cf8f2ee2c8ec6;p=users%2Fhch%2Fnvme-cli.git

micron: don't ignore 'system()' return value

Some compilers will generate warnings that this return value can't be
ignored.

Signed-off-by: Keith Busch <kbusch@kernel.org>
---

diff --git a/plugins/micron/micron-nvme.c b/plugins/micron/micron-nvme.c
index ff19157..8240887 100644
--- a/plugins/micron/micron-nvme.c
+++ b/plugins/micron/micron-nvme.c
@@ -73,7 +73,7 @@ static int ZipAndRemoveDir(char *strDirName, char *strFileName)
 	}
 
  exit_status:
-	(void)system("rm -f temp.txt");
+	err = system("rm -f temp.txt");
 	return err;
 }
 
@@ -960,7 +960,8 @@ static void GetOSConfig(const char *strOSDirName)
 		}
 		strcpy(strTemp, cmdArray[i].strCommand);
 		sprintf(strBuffer, strTemp, strFileName);
-		(void)system(strBuffer);
+		if (system(strBuffer))
+			fprintf(stderr, "Failed to send \"%s\"\n", strBuffer);
 	}
 }