From: Dan Carpenter Date: Thu, 6 Jan 2022 07:18:25 +0000 (+0300) Subject: iwlwifi: mvm: fix off by one in iwl_mvm_stat_iterator_all_macs() X-Git-Tag: v5.17.2~563 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=a82a8fe66d872cb7327a5d7757f9c01f6da95494;p=users%2Fdwmw2%2Flinux.git iwlwifi: mvm: fix off by one in iwl_mvm_stat_iterator_all_macs() [ Upstream commit f1cbb0a8ca9db80c086009c88c71464ac50f50a2 ] Change the comparison from ">" to ">=" to avoid accessing one element beyond the end of the ->per_mac_stats[] array. Fixes: 6324c173ff4a ("iwlwifi: mvm: add support for statistics update version 15") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20220106071825.GA5836@kili Signed-off-by: Luca Coelho Signed-off-by: Sasha Levin --- diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rx.c b/drivers/net/wireless/intel/iwlwifi/mvm/rx.c index 64446a11ef980..9a46468bd4345 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/rx.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rx.c @@ -640,7 +640,7 @@ static void iwl_mvm_stat_iterator_all_macs(void *_data, u8 *mac, struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif); u16 vif_id = mvmvif->id; - if (WARN_ONCE(vif_id > MAC_INDEX_AUX, "invalid vif id: %d", vif_id)) + if (WARN_ONCE(vif_id >= MAC_INDEX_AUX, "invalid vif id: %d", vif_id)) return; if (vif->type != NL80211_IFTYPE_STATION)