From: David Oberhollenzer Date: Tue, 9 Jul 2019 10:22:30 +0000 (+0200) Subject: mkfs.ubifs: remove ZSTD_CLEVEL_DEFAULT for backwards compatibillity X-Git-Tag: v2.1.1~3 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=a6d5eedb9ed112474ab1988013fc812bc6056c7a;p=mtd-utils.git mkfs.ubifs: remove ZSTD_CLEVEL_DEFAULT for backwards compatibillity Support for ZSTD compression has been added recently through the ZSTD library, which is famously known for its incredibly well designed and stable API. This patch removes usage of ZSTD_CLEVEL_DEFAULT, which isn't exposed in older versions of the ZSTD library, and replaces it with with the constant parameter 0. According to the documentation this should then use a reasonable default (which is defined internally). Other possible approachs include defining ZSTD_CLEVEL_DEFAULT to 3 (the value it _currently_ has) if it isn't defined. This patch chooses the approach of passing 0 since this seems to be encouraged by the existing documentation. Signed-off-by: David Oberhollenzer --- diff --git a/ubifs-utils/mkfs.ubifs/compr.c b/ubifs-utils/mkfs.ubifs/compr.c index 6239835..9eade89 100644 --- a/ubifs-utils/mkfs.ubifs/compr.c +++ b/ubifs-utils/mkfs.ubifs/compr.c @@ -120,8 +120,7 @@ static int zstd_compress(void *in_buf, size_t in_len, void *out_buf, { size_t ret; - ret = ZSTD_compressCCtx(zctx, out_buf, *out_len, in_buf, in_len, - ZSTD_CLEVEL_DEFAULT); + ret = ZSTD_compressCCtx(zctx, out_buf, *out_len, in_buf, in_len, 0); if (ZSTD_isError(ret)) { errcnt += 1; return -1;