From: Sowmini Varadhan Date: Thu, 6 Jul 2017 15:15:06 +0000 (-0700) Subject: rds: tcp: use sock_create_lite() to create the accept socket X-Git-Tag: v4.1.12-107.0.20170801_2000~62 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=a670499f5a9a;p=users%2Fjedix%2Flinux-maple.git rds: tcp: use sock_create_lite() to create the accept socket There are two problems with calling sock_create_kern() from rds_tcp_accept_one() 1. it sets up a new_sock->sk that is wasteful, because this ->sk is going to get replaced by inet_accept() in the subsequent ->accept() 2. The new_sock->sk is a leaked reference in sock_graft() which expects to find a null parent->sk Avoid these problems by calling sock_create_lite(). Orabug: 26477756 Signed-off-by: Sowmini Varadhan Acked-by: Santosh Shilimkar Reviewed-by: Yuval Shaia --- diff --git a/net/rds/tcp_listen.c b/net/rds/tcp_listen.c index 4864960db55a..00e6a461219c 100644 --- a/net/rds/tcp_listen.c +++ b/net/rds/tcp_listen.c @@ -127,7 +127,7 @@ int rds_tcp_accept_one(struct socket *sock) if (!sock) /* module unload or netns delete in progress */ return -ENETUNREACH; - ret = sock_create_kern(sock_net(sock->sk), sock->sk->sk_family, + ret = sock_create_lite(sock->sk->sk_family, sock->sk->sk_type, sock->sk->sk_protocol, &new_sock); if (ret)