From: Jing Xiangfeng <jingxiangfeng@huawei.com>
Date: Fri, 24 Jul 2020 03:54:30 +0000 (+0800)
Subject: ARM: OMAP2+: Fix an IS_ERR() vs NULL check in _get_pwrdm()
X-Git-Tag: v5.9-rc5~1^2~2^2~4
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=a58cfdba2039ff2d5758840e97a23a2dedecf1e8;p=users%2Fdwmw2%2Flinux.git

ARM: OMAP2+: Fix an IS_ERR() vs NULL check in _get_pwrdm()

The of_clk_get() function returns error pointers, it never returns NULL.

Fixes: 4ea3711aece4 ("ARM: OMAP2+: omap-iommu.c conversion to ti-sysc")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---

diff --git a/arch/arm/mach-omap2/omap-iommu.c b/arch/arm/mach-omap2/omap-iommu.c
index 54aff33e55e6e..bfa5e1b8dba7f 100644
--- a/arch/arm/mach-omap2/omap-iommu.c
+++ b/arch/arm/mach-omap2/omap-iommu.c
@@ -74,7 +74,7 @@ static struct powerdomain *_get_pwrdm(struct device *dev)
 		return pwrdm;
 
 	clk = of_clk_get(dev->of_node->parent, 0);
-	if (!clk) {
+	if (IS_ERR(clk)) {
 		dev_err(dev, "no fck found\n");
 		return NULL;
 	}