From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: Thu, 23 Jan 2020 15:22:40 +0000 (+0000)
Subject: hw/misc/stm32f4xx_syscfg: Fix copy/paste error
X-Git-Tag: v5.0.0-rc0~129^2~8
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=a4abb6f2061f3a40f01cfe4c79c1527db655ac89;p=users%2Fdwmw2%2Fqemu.git

hw/misc/stm32f4xx_syscfg: Fix copy/paste error

Missed in 870c034da0b, hopefully reported by Coverity.

Fixes: Coverity CID 1412793 (Incorrect expression)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 20200121213853.9601-1-f4bug@amsat.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---

diff --git a/hw/misc/stm32f4xx_syscfg.c b/hw/misc/stm32f4xx_syscfg.c
index dbcdca59f8..f960e4ea1e 100644
--- a/hw/misc/stm32f4xx_syscfg.c
+++ b/hw/misc/stm32f4xx_syscfg.c
@@ -47,7 +47,7 @@ static void stm32f4xx_syscfg_set_irq(void *opaque, int irq, int level)
     STM32F4xxSyscfgState *s = opaque;
     int icrreg = irq / 4;
     int startbit = (irq & 3) * 4;
-    uint8_t config = config = irq / 16;
+    uint8_t config = irq / 16;
 
     trace_stm32f4xx_syscfg_set_irq(irq / 16, irq % 16, level);