From: Yafang Shao Date: Tue, 6 Feb 2024 08:14:14 +0000 (+0800) Subject: selftests/bpf: Fix error checking for cpumask_success__load() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=a2bff65cfca93f0fe4c5996f55ce8f413e85e4fe;p=users%2Fjedix%2Flinux-maple.git selftests/bpf: Fix error checking for cpumask_success__load() We should verify the return value of cpumask_success__load(). Signed-off-by: Yafang Shao Signed-off-by: Andrii Nakryiko Acked-by: Andrii Nakryiko Link: https://lore.kernel.org/bpf/20240206081416.26242-4-laoar.shao@gmail.com --- diff --git a/tools/testing/selftests/bpf/prog_tests/cpumask.c b/tools/testing/selftests/bpf/prog_tests/cpumask.c index c2e886399e3c..ecf89df78109 100644 --- a/tools/testing/selftests/bpf/prog_tests/cpumask.c +++ b/tools/testing/selftests/bpf/prog_tests/cpumask.c @@ -27,7 +27,7 @@ static void verify_success(const char *prog_name) struct bpf_program *prog; struct bpf_link *link = NULL; pid_t child_pid; - int status; + int status, err; skel = cpumask_success__open(); if (!ASSERT_OK_PTR(skel, "cpumask_success__open")) @@ -36,8 +36,8 @@ static void verify_success(const char *prog_name) skel->bss->pid = getpid(); skel->bss->nr_cpus = libbpf_num_possible_cpus(); - cpumask_success__load(skel); - if (!ASSERT_OK_PTR(skel, "cpumask_success__load")) + err = cpumask_success__load(skel); + if (!ASSERT_OK(err, "cpumask_success__load")) goto cleanup; prog = bpf_object__find_program_by_name(skel->obj, prog_name);