From: Knut Omang Date: Wed, 10 Aug 2016 07:49:49 +0000 (+0200) Subject: sif: Remove write access to the module parameters cb_max and cq_eq_max X-Git-Tag: v4.1.12-92~87^2~9 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=9f8f7c500406c039b955fbf263fccece8f4a39f8;p=users%2Fjedix%2Flinux-maple.git sif: Remove write access to the module parameters cb_max and cq_eq_max Writing to these parameters after driver load does not have the desired effect so tit should be prohibited. Orabug: 24437094 Signed-off-by: Knut Omang Reviewed-by: Håkon Bugge --- diff --git a/drivers/infiniband/hw/sif/sif_main.c b/drivers/infiniband/hw/sif/sif_main.c index 4c9e6e52a1d5..e8c0d7debbc9 100644 --- a/drivers/infiniband/hw/sif/sif_main.c +++ b/drivers/infiniband/hw/sif/sif_main.c @@ -102,12 +102,12 @@ MODULE_PARM_DESC(ki_spqp_size, "Number of privileged QPs for key invalidate sten /* pqp_size == cq_eq_max */ uint sif_cq_eq_max = 46; -module_param_named(cq_eq_max, sif_cq_eq_max, uint, S_IRUGO | S_IWUSR); +module_param_named(cq_eq_max, sif_cq_eq_max, uint, S_IRUGO); MODULE_PARM_DESC(cq_eq_max, "Upper limit on no. of EQs to distribute completion events among"); uint sif_cb_max = 100; -module_param_named(cb_max, sif_cb_max, uint, S_IRUGO | S_IWUSR); -MODULE_PARM_DESC(cb_max, "Upper limit on no. of CBs."); +module_param_named(cb_max, sif_cb_max, uint, S_IRUGO); +MODULE_PARM_DESC(cb_max, "Upper limit on no. of CBs of each type to reserve for the kernel"); uint sif_fmr_cache_flush_threshold = 512; module_param_named(fmr_cache_flush_threshold, sif_fmr_cache_flush_threshold, uint, S_IRUGO | S_IWUSR);