From: Jia-Ju Bai Date: Fri, 27 Jul 2018 02:41:09 +0000 (+0800) Subject: isdn: mISDN: netjet: Replace GFP_ATOMIC with GFP_KERNEL in nj_probe() X-Git-Tag: v4.19-rc1~140^2~237 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=9d8009dee92cc97f866403da1b306e6e29fc12cc;p=users%2Fjedix%2Flinux-maple.git isdn: mISDN: netjet: Replace GFP_ATOMIC with GFP_KERNEL in nj_probe() nj_probe() is never called in atomic context. It calls kzalloc() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai Signed-off-by: David S. Miller --- diff --git a/drivers/isdn/hardware/mISDN/netjet.c b/drivers/isdn/hardware/mISDN/netjet.c index 89d9ba8ed535..2b317cb63d06 100644 --- a/drivers/isdn/hardware/mISDN/netjet.c +++ b/drivers/isdn/hardware/mISDN/netjet.c @@ -1084,7 +1084,7 @@ nj_probe(struct pci_dev *pdev, const struct pci_device_id *ent) return -ENODEV; } - card = kzalloc(sizeof(struct tiger_hw), GFP_ATOMIC); + card = kzalloc(sizeof(struct tiger_hw), GFP_KERNEL); if (!card) { pr_info("No kmem for Netjet\n"); return err;