From: Zhihao Cheng <chengzhihao1@huawei.com>
Date: Sun, 26 Jan 2025 06:41:58 +0000 (+0800)
Subject: nand-utils: nanddump: Fix unexpected type compiling warning for argument 'dumpfile'
X-Git-Tag: v2.3.0~7
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=9d755ba03f6947ed0f77df8a2bcdb1b6585dabf9;p=mtd-utils.git

nand-utils: nanddump: Fix unexpected type compiling warning for argument 'dumpfile'

The const pointer argument cannot be passed into libc function 'free()',
otherwise the compiler will complain following message:
 nand-utils/nanddump.c:168:10: warning: passing argument 1 of ‘free’
 discards ‘const’ qualifier from pointer target type

Fixes: c89009463888 ("nanddump: don't leak copied command line arguments")
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
---

diff --git a/nand-utils/nanddump.c b/nand-utils/nanddump.c
index bc22858..b4de05e 100644
--- a/nand-utils/nanddump.c
+++ b/nand-utils/nanddump.c
@@ -102,6 +102,7 @@ static void process_options(int argc, char * const argv[])
 {
 	int error = 0;
 	bool oob_default = true;
+	char *dumpfile_tmp = NULL;
 
 	for (;;) {
 		int option_index = 0;
@@ -165,8 +166,8 @@ static void process_options(int argc, char * const argv[])
 				start_addr = simple_strtoll(optarg, &error);
 				break;
 			case 'f':
-				free(dumpfile);
-				dumpfile = xstrdup(optarg);
+				free(dumpfile_tmp);
+				dumpfile = dumpfile_tmp = xstrdup(optarg);
 				break;
 			case 'l':
 				length = simple_strtoll(optarg, &error);