From: weiyongjun (A) <weiyongjun1@huawei.com>
Date: Fri, 5 Jan 2018 01:50:59 +0000 (+0000)
Subject: clk: meson-axg: fix potential NULL dereference in axg_clkc_probe()
X-Git-Tag: v4.16-rc1~97^2~1^5
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=9d548d80384732bad74c3046329e5dbdae098104;p=users%2Fjedix%2Flinux-maple.git

clk: meson-axg: fix potential NULL dereference in axg_clkc_probe()

platform_get_resource() may return NULL, add proper
check to avoid potential NULL dereferencing.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---

diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c
index d883bef49eb70..1294f3ad7cd59 100644
--- a/drivers/clk/meson/axg.c
+++ b/drivers/clk/meson/axg.c
@@ -879,6 +879,8 @@ static int axg_clkc_probe(struct platform_device *pdev)
 
 	/*  Generic clocks and PLLs */
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!res)
+		return -EINVAL;
 	clk_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
 	if (!clk_base) {
 		dev_err(&pdev->dev, "Unable to map clk base\n");