From: Vlastimil Babka <vbabka@suse.cz>
Date: Wed, 3 Sep 2025 12:59:44 +0000 (+0200)
Subject: slab: simplify init_kmem_cache_nodes() error handling
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=9d4e6ab865c48c70e684b176d3ee1574d092626f;p=users%2Fhch%2Fmisc.git

slab: simplify init_kmem_cache_nodes() error handling

We don't need to call free_kmem_cache_nodes() immediately when failing
to allocate a kmem_cache_node, because when we return 0,
do_kmem_cache_create() calls __kmem_cache_release() which also performs
free_kmem_cache_nodes().

Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
Reviewed-by: Suren Baghdasaryan <surenb@google.com>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
---

diff --git a/mm/slub.c b/mm/slub.c
index 30003763d224..9f671ec76131 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -5669,10 +5669,8 @@ static int init_kmem_cache_nodes(struct kmem_cache *s)
 		n = kmem_cache_alloc_node(kmem_cache_node,
 						GFP_KERNEL, node);
 
-		if (!n) {
-			free_kmem_cache_nodes(s);
+		if (!n)
 			return 0;
-		}
 
 		init_kmem_cache_node(n);
 		s->node[node] = n;