From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: Wed, 5 May 2021 21:37:45 +0000 (+0200)
Subject: mtd: rawnand: Allow SDR timings to be nacked
X-Git-Tag: howlett/maple/20220722_2~2820^2~1^2~33
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=9d3194bf2aef81c04177ab6bbe50406aa8d550dc;p=users%2Fjedix%2Flinux-maple.git

mtd: rawnand: Allow SDR timings to be nacked

This should never happen in theory and is probably a controller driver
bug. Anyway it's probably better to bail out at this point if this
happens rather than continuing the boot process.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20210505213750.257417-18-miquel.raynal@bootlin.com
---

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index cfe8257bf1751..e20551cb3ce59 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -952,13 +952,13 @@ int nand_choose_best_sdr_timings(struct nand_chip *chip,
 
 		ret = ops->setup_interface(chip, NAND_DATA_IFACE_CHECK_ONLY,
 					   iface);
-		if (!ret)
+		if (!ret) {
+			chip->best_interface_config = iface;
 			break;
+		}
 	}
 
-	chip->best_interface_config = iface;
-
-	return 0;
+	return ret;
 }
 
 /**