From: Sanket Goswami Date: Tue, 21 Sep 2021 11:59:10 +0000 (+0530) Subject: platform/x86: amd-pmc: Send command to dump data after clearing OS_HINT X-Git-Tag: v5.16-rc1~139^2~65 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=9c93f8f4fc8cd938bc0ee8d121809c6941e03347;p=linux-platform-drivers-x86.git platform/x86: amd-pmc: Send command to dump data after clearing OS_HINT It was reported that the resume stats received from the firmware are always zero. This happens because the SMU expects the driver to send the command to dump the log data after clearing the OS_HINT. Adjust the order of the commands sent to SMU. Signed-off-by: Shyam Sundar S K Signed-off-by: Sanket Goswami Link: https://lore.kernel.org/r/20210921115910.19401-1-Sanket.Goswami@amd.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede --- diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c index f185c43bbaa4..d4d2ba886f4e 100644 --- a/drivers/platform/x86/amd-pmc.c +++ b/drivers/platform/x86/amd-pmc.c @@ -436,14 +436,14 @@ static int __maybe_unused amd_pmc_resume(struct device *dev) int rc; u8 msg; - /* Let SMU know that we are looking for stats */ - amd_pmc_send_cmd(pdev, 0, NULL, SMU_MSG_LOG_DUMP_DATA, 0); - msg = amd_pmc_get_os_hint(pdev); rc = amd_pmc_send_cmd(pdev, 0, NULL, msg, 0); if (rc) dev_err(pdev->dev, "resume failed\n"); + /* Let SMU know that we are looking for stats */ + amd_pmc_send_cmd(pdev, 0, NULL, SMU_MSG_LOG_DUMP_DATA, 0); + /* Dump the IdleMask to see the blockers */ amd_pmc_idlemask_read(pdev, dev, NULL);