From: Lu Fengqi Date: Mon, 2 Jul 2018 07:00:01 +0000 (+0800) Subject: build: fix undefined macro: AC_PACKAGE_NEED_GETXATTR_LIBATTR X-Git-Tag: v2022.05.01~1465 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=9b846275d61a80f69f85927287e4843845420e4c;p=users%2Fhch%2Fxfstests-dev.git build: fix undefined macro: AC_PACKAGE_NEED_GETXATTR_LIBATTR Because the macro AC_PACKAGE_NEED_GETXATTR_LIBATTR was removed by the following commit specified by fixes tag, we also need remove AC_PACKAGE_NEED_GETXATTR_LIBATTR from configure.ac. In addition, the libattr will not be set after the macro being removed. This cause gcc fail to link the libattr for fsstress correctly. The macro AC_PACKAGE_NEED_ATTRGET_LIBATTR has been obsoleted, so change it to AC_PACKAGE_NEED_ATTRSET_LIBATTR and add it to configure.ac. It can help check libattr and set libattr variable. Fixes: 42b851446ff1 ("build: remove check") Reported-by: Zorro Lang Signed-off-by: Lu Fengqi Reviewed-by: Eryu Guan Tested-by: Darrick J. Wong Signed-off-by: Eryu Guan --- diff --git a/configure.ac b/configure.ac index 63ea032dc..aede4f59a 100644 --- a/configure.ac +++ b/configure.ac @@ -53,7 +53,7 @@ AC_PACKAGE_NEED_XFS_HANDLE_H AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE AC_PACKAGE_NEED_ATTRIBUTES_H AC_PACKAGE_WANT_ATTRLIST_LIBATTR -AC_PACKAGE_NEED_GETXATTR_LIBATTR +AC_PACKAGE_NEED_ATTRSET_LIBATTR AC_PACKAGE_NEED_SYS_ACL_H AC_PACKAGE_NEED_ACL_LIBACL_H diff --git a/m4/package_attrdev.m4 b/m4/package_attrdev.m4 index 9a82f241d..d994cfc23 100644 --- a/m4/package_attrdev.m4 +++ b/m4/package_attrdev.m4 @@ -26,8 +26,8 @@ AC_DEFUN([AC_PACKAGE_WANT_ATTRLIST_LIBATTR], AC_SUBST(have_attr_list) ]) -AC_DEFUN([AC_PACKAGE_NEED_ATTRGET_LIBATTR], - [ AC_CHECK_LIB(attr, attr_get,, [ +AC_DEFUN([AC_PACKAGE_NEED_ATTRSET_LIBATTR], + [ AC_CHECK_LIB(attr, attr_set,, [ echo echo 'FATAL ERROR: could not find a valid Extended Attributes library.' echo 'Install the extended attributes (attr) development package.'