From: Jinliang Wang <jinliangw@google.com>
Date: Fri, 25 Nov 2022 07:44:19 +0000 (-0800)
Subject: mi: rename tmp variable inside nvme_mi_admin_get_log
X-Git-Tag: v1.3~20^2
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=9ac9f8ae7ae246838bdbe2110b6609df417e1bd3;p=users%2Fsagi%2Flibnvme.git

mi: rename tmp variable inside nvme_mi_admin_get_log

rename the `tmp` variable into `xfered_size`.
It is hard to figure out a name which can imply that this variable
is used as both input and output parameter, so I choose `xfered_size`
to emphasize the output functionality.

Signed-off-by: Jinliang Wang <jinliangw@google.com>
---

diff --git a/src/nvme/mi.c b/src/nvme/mi.c
index 1a34208e..ed112f65 100644
--- a/src/nvme/mi.c
+++ b/src/nvme/mi.c
@@ -839,7 +839,7 @@ static int __nvme_mi_admin_get_log(nvme_mi_ctrl_t ctrl,
 
 int nvme_mi_admin_get_log(nvme_mi_ctrl_t ctrl, struct nvme_get_log_args *args)
 {
-	const size_t xfer_size = 4096;
+	const size_t max_xfer_size = 4096;
 	off_t xfer_offset;
 	int rc = 0;
 
@@ -849,25 +849,26 @@ int nvme_mi_admin_get_log(nvme_mi_ctrl_t ctrl, struct nvme_get_log_args *args)
 	}
 
 	for (xfer_offset = 0; xfer_offset < args->len;) {
-		size_t tmp, cur_xfer_size = xfer_size;
+		size_t xfered_size, cur_xfer_size = max_xfer_size;
 		bool final;
 
 		if (xfer_offset + cur_xfer_size > args->len)
 			cur_xfer_size = args->len - xfer_offset;
 
-		tmp = cur_xfer_size;
+		xfered_size = cur_xfer_size;
 
 		final = xfer_offset + cur_xfer_size >= args->len;
 
+		/* xfered_size is used as both input and output parameter */
 		rc = __nvme_mi_admin_get_log(ctrl, args, xfer_offset,
-					     &tmp, final);
+					     &xfered_size, final);
 		if (rc)
 			break;
 
-		xfer_offset += tmp;
+		xfer_offset += xfered_size;
 		/* if we returned less data than expected, consider that
 		 * the end of the log page */
-		if (tmp != cur_xfer_size)
+		if (xfered_size != cur_xfer_size)
 			break;
 	}