From: Kemeng Shi <shikemeng@huaweicloud.com>
Date: Fri, 3 Mar 2023 17:21:12 +0000 (+0800)
Subject: ext4: remove dead check in mb_buddy_mark_free
X-Git-Tag: kvm-6.4-2~106^2~73
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=976620bd261025c86bafe79c15170dc3da7a66f4;p=users%2Fdwmw2%2Flinux.git

ext4: remove dead check in mb_buddy_mark_free

We always adjust first to even number and adjust last to odd number, so
first == last will never happen. Remove this dead check.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Link: https://lore.kernel.org/r/20230303172120.3800725-13-shikemeng@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 65dac09c4cea2..591bd8e5e5c7b 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1718,7 +1718,8 @@ static void mb_buddy_mark_free(struct ext4_buddy *e4b, int first, int last)
 			break;
 		order++;
 
-		if (first == last || !(buddy2 = mb_find_buddy(e4b, order, &max))) {
+		buddy2 = mb_find_buddy(e4b, order, &max);
+		if (!buddy2) {
 			mb_clear_bits(buddy, first, last - first + 1);
 			e4b->bd_info->bb_counters[order - 1] += last - first + 1;
 			break;