From: Benjamin Bara Date: Tue, 3 Sep 2024 14:54:34 +0000 (+0200) Subject: media: i2c: imx290: Check for availability in probe() X-Git-Tag: v6.13-rc1~149^2~154 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=9755343cb27ef0b0a82e196e2e4d2d3c3a275163;p=linux.git media: i2c: imx290: Check for availability in probe() Currently, the V4L2 subdevice is also created when the device is not available/connected. From userspace perspective, there is no visible difference between a working and not-working subdevice (except when trying it out). This commit adds a simple preparation step, which includes an availability check, before the subdev is initialized. Signed-off-by: Benjamin Bara Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c index 47cfb6a9e9b5..49a5bf9c17da 100644 --- a/drivers/media/i2c/imx290.c +++ b/drivers/media/i2c/imx290.c @@ -1589,6 +1589,16 @@ static int imx290_probe(struct i2c_client *client) pm_runtime_set_autosuspend_delay(dev, 1000); pm_runtime_use_autosuspend(dev); + /* + * Make sure the sensor is available, in STANDBY and not streaming + * before the V4L2 subdev is initialized. + */ + ret = imx290_stop_streaming(imx290); + if (ret) { + ret = dev_err_probe(dev, ret, "Could not initialize device\n"); + goto err_pm; + } + /* Initialize the V4L2 subdev. */ ret = imx290_subdev_init(imx290); if (ret)