From: Christoph Hellwig Date: Thu, 30 Jun 2022 16:15:11 +0000 (+0200) Subject: nits X-Git-Tag: draft-hellwig-nfsv4-scsi-layout-nvme-03~11 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=958d908a2b013fb4fd090541b9d0a8727201f06e;p=users%2Fhch%2Fscsi-layout-nvme.git nits From David Black --- diff --git a/scsi_nvme_middle.xml b/scsi_nvme_middle.xml index 839b8f0..76f964d 100644 --- a/scsi_nvme_middle.xml +++ b/scsi_nvme_middle.xml @@ -84,7 +84,7 @@ To be used as storage devices for the pNFS SCSI layout, NVMe namespaces - MUST support either the EUI64 or NGUID value reported in an Namespace + MUST support either the EUI64 or NGUID value reported in a Namespace Identification Descriptor, the I/O Command Set Independent Identify Namespace Data Structure, and the Identify Namespace Data Structure, NVM Command Set. If available, the NGUID value SHOULD be used as it is @@ -97,16 +97,16 @@ - The pnfs_scsi_base_volume_info4 structure shall be constructed as - following: + The pnfs_scsi_base_volume_info4 structure for an NVMe namespace + SHALL be constructed as follows: The "sbv_code_set" field SHALL be set to PS_CODE_SET_BINARY. The "pnfs_scsi_designator_type" field SHALL be set to PS_DESIGNATOR_EUI64. The "sbv_designator" field SHALL contain either the NGUID or - the EUI64 identifier from NVMe Identify Namespace data. If - both NGUID and EUI64 identifiers are available, then the NGUID - identifier SHOULD be used as it is the larger identifier. + the EUI64 identifier from the namespace. If both NGUID and EUI64 + identifiers are available, then the NGUID identifier SHOULD be + used as it is the larger identifier. @@ -116,7 +116,7 @@ its XDR representation) indicates which NVMe identifier is present. That length MUST be 16 octets for an NVMe NGUID identifier and MUST be 8 octets for an NVMe EUI64 identifier. All other lengths - MUST NOT be used with NVMe. + MUST NOT be used with an NVMe namespace.