From: Arnd Bergmann Date: Mon, 1 Feb 2016 16:29:45 +0000 (+0100) Subject: target/user: Fix cast from pointer to phys_addr_t X-Git-Tag: v4.1.12-105.0.20170622_2100~25 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=955acc3d0caf07915bc1b2f82a09b0cb5e769d4b;p=users%2Fjedix%2Flinux-maple.git target/user: Fix cast from pointer to phys_addr_t The uio_mem structure has a member that is a phys_addr_t, but can be a number of other types too. The target core driver attempts to assign a pointer from vmalloc() to it, by casting it to phys_addr_t, but that causes a warning when phys_addr_t is longer than a pointer: drivers/target/target_core_user.c: In function 'tcmu_configure_device': drivers/target/target_core_user.c:906:22: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] This adds another cast to uintptr_t to shut up the warning. A nicer fix might be to have additional fields in uio_mem for the different purposes, so we can assign a pointer directly. Signed-off-by: Arnd Bergmann Signed-off-by: Nicholas Bellinger Orabug: 25395066 (cherry picked from commit 0633e123465b61a12a262b742bebf2a9945f7964) Signed-off-by: Kyle Fortin Reviewed-by: Shan Hai --- diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index 08446dc44d9e6..1fda29594114c 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -901,7 +901,7 @@ static int tcmu_configure_device(struct se_device *dev) info->version = __stringify(TCMU_MAILBOX_VERSION); info->mem[0].name = "tcm-user command & data buffer"; - info->mem[0].addr = (phys_addr_t) udev->mb_addr; + info->mem[0].addr = (phys_addr_t)(uintptr_t)udev->mb_addr; info->mem[0].size = TCMU_RING_SIZE; info->mem[0].memtype = UIO_MEM_VIRTUAL;