From: Dinghao Liu <dinghao.liu@zju.edu.cn>
Date: Thu, 28 May 2020 07:21:04 +0000 (+0800)
Subject: hwrng: ks-sa - Fix runtime PM imbalance on error
X-Git-Tag: v5.8-rc2~5^2~7
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=95459261c99f1621d90bc628c2a48e60b7cf9a88;p=users%2Fjedix%2Flinux-maple.git

hwrng: ks-sa - Fix runtime PM imbalance on error

pm_runtime_get_sync() increments the runtime PM usage counter even
the call returns an error code. Thus a pairing decrement is needed
on the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/drivers/char/hw_random/ks-sa-rng.c b/drivers/char/hw_random/ks-sa-rng.c
index e2330e757f1f..001617033d6a 100644
--- a/drivers/char/hw_random/ks-sa-rng.c
+++ b/drivers/char/hw_random/ks-sa-rng.c
@@ -244,6 +244,7 @@ static int ks_sa_rng_probe(struct platform_device *pdev)
 	ret = pm_runtime_get_sync(dev);
 	if (ret < 0) {
 		dev_err(dev, "Failed to enable SA power-domain\n");
+		pm_runtime_put_noidle(dev);
 		pm_runtime_disable(dev);
 		return ret;
 	}